Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildMix: fix: initial try #112477
buildMix: fix: initial try #112477
Changes from all commits
f0b6a46
1b1af19
481832b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure those variables should be in the unit file: for the
RELEASE_TMP
variable, I think I recall it being useful for thedaemon
andeval
commands, which can be used outside of the service. For theRELEASE_COOKIE
, I don't think it should be world-readable in the nix store, and is also used outside of the service for controlling a running elixir project, for example. If you do not mind, since I will be making a PR for generically overriding theruntime.exs
file, I can also add the wrapper that sets RELEASE_TMP and RELEASE_COOKIE in that same function, like I did partially hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right the release cookie shouldn't be there.
I'll remove it and add a TODO to add the documentation regarding the release cookie later on
This file was deleted.