Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnuradio3_8: 3.8.2.0 -> 3.8.3.0 #118347

Merged
merged 1 commit into from
Apr 4, 2021
Merged

gnuradio3_8: 3.8.2.0 -> 3.8.3.0 #118347

merged 1 commit into from
Apr 4, 2021

Conversation

eduardosm
Copy link
Contributor

@eduardosm eduardosm commented Apr 2, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eduardosm
Copy link
Contributor Author

cc @doronbehar

@SuperSandro2000
Copy link
Member

Maybe this helps you gnuradio/gnuradio#4278 drowe67/codec2#60 . I think their toolchain is not supporting layouts like nix has quite well.

@ofborg ofborg bot requested review from bjornfor, doronbehar and fpletz April 2, 2021 19:13
@eduardosm eduardosm changed the title [WIP][need help] gnuradio3_8: 3.8.2.0 -> 3.8.3.0 gnuradio3_8: 3.8.2.0 -> 3.8.3.0 Apr 3, 2021
@eduardosm
Copy link
Contributor Author

Fixed by adding -DLIBCODEC2_FOUND=TRUE and -DLIBGSM_FOUND=TRUE. Maybe this will work for gr3.9 too.

@eduardosm eduardosm marked this pull request as ready for review April 3, 2021 12:36
@doronbehar
Copy link
Contributor

Can be merged if ofborg is green, I'm going to sleep. Ping me if it's not merged by tomorrow :).

@ofborg ofborg bot requested a review from doronbehar April 3, 2021 20:49
@eduardosm
Copy link
Contributor Author

@doronbehar Remember to merge :)

@risicle
Copy link
Contributor

risicle commented Apr 4, 2021

WFM linux x86_64

@risicle risicle merged commit ee33b8b into NixOS:master Apr 4, 2021
@eduardosm eduardosm deleted the gr3.8 branch April 4, 2021 16:52
SuperSandro2000
SuperSandro2000 reviewed Apr 4, 2021
View reviewed changes
pkgs/applications/radio/gnuradio/3.8.nix
patches = [
# Don't install python referencing files if python support is disabled.
# See: https://github.com/gnuradio/gnuradio/pull/3839
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove fetchpatch from inputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#118496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@bjornfor bjornfor Awaiting requested review from bjornfor

@fpletz fpletz Awaiting requested review from fpletz

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eduardosm @SuperSandro2000 @doronbehar @risicle