Update vscode python #121072
Merged
Update vscode python #121072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinnison
force-pushed
the
update-vscode-python
branch
from
584a942 to
c93888b
Compare
ofborg
bot
added
8.has: package (new)
|
Result of 2 packages built successfully:
|
This splits off part of the Python extension into Microsoft's jupyter extension, so this is necessary but not sufficient. Signed-off-by: Daniel Silverstone <[email protected]>
This is a necessary dependency of the new Python extension for VSCode. Signed-off-by: Daniel Silverstone <[email protected]>
In order for the ms-python.python extension to work these days, we also need the ms-toolsai.jupyter extension. To permit easy upgrades and to honour the principle of least surprise, we wrapper the Python extension to include the Jupyter one. The reverse is not true, you *can* have the Jupyter extension without the Python one, so the reverse is not also done. Signed-off-by: Daniel Silverstone <[email protected]>
kinnison
force-pushed
the
update-vscode-python
branch
from
c93888b to
b71773e
Compare
|
I have confirmed the closure sizes, checked again against CONTRIBUTING and rebased against current master. |
|
@jonringer Do you need me to do anything else for this, or is it simply a case of "when you have time to consider it again" ? |
Closed
lukegb
reviewed
May 8, 2021
SuperSandro2000
pushed a commit
that referenced
this pull request
Jun 25, 2021
SuperSandro2000
added a commit
that referenced
this pull request
Jun 25, 2021
vscode-extensions.ms-python.python: revert #121072
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Microsoft updated their Python extension for vscode in April 2021. This isn't a straightforward upgrade since it splits some of the functionality out into their Jupyter extension (which is also unfree :( )
However if we don't update then anyone installing their vscode extensions via nix will suffer with vscode bugging them about the extension being updatable until they eventually crack and end up with an extension installed in their homedir rather than declaratively.
I tested this via swapping out my "unstable" nixpkgs flake in my system configuration and rebuilding to confirm the new python extension was installed along with the Jupyter one automatically.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)