darwin packages: Get ready for cross #122527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
veprbl
reviewed
May 11, 2021
pkgs/os-specific/darwin/apple-source-releases/configd/default.nix
Outdated
Show resolved
Hide resolved
| callPackage = self.newScope { inherit appleDerivation; }; | ||
| appleDerivation' = stdenv: appleDerivation'' stdenv pname version sdkName sha256; | ||
| appleDerivation = appleDerivation' stdenv; | ||
| callPackage = self.newScope { inherit appleDerivation' appleDerivation; }; |
There was a problem hiding this comment.
Well appleDerivation' takes an arbitrary stdenv. I think I would like that to just replace appleDerivation eventually.
pkgs/os-specific/darwin/apple-source-releases/libresolv/default.nix
Outdated
Show resolved
Hide resolved
|
Does this allow to cross-compile darwin on Linux? |
Ericson2314
force-pushed
the
darwin-no-cc-where-possible
branch
2 times, most recently
from
f013127 to
d4a63a9
Compare
|
@Mic92 No, but I believe it is "getting the mass rebuilds out of the way". I have another commit with an actual attempt at that which I think might work better after @thefloweringash's darwin -> darwin attempt. |
If things build fine with `stdenvNoCC`, let them use that. If tools might be prefixed, prepare for that, either by directly splicing or just using the env vars provided by the wrapper setup-hooks. Co-authored-by: Dmitry Kalinkin <[email protected]>
Ericson2314
force-pushed
the
darwin-no-cc-where-possible
branch
from
d4a63a9 to
7bba32a
Compare
|
Rebuilt darwin stdenv and hello just to double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
If things build fine with
stdenvNoCC, let them use that. If toolsmight be prefixed, prepare for that.
This is a mass rebuild, but I don't think the final stdenv should be any different in contents, so I think it's safe.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)