Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang-ls: init at 0.15.0 #122646

Merged
merged 1 commit into from
May 12, 2021
Merged

erlang-ls: init at 0.15.0 #122646

merged 1 commit into from
May 12, 2021

Conversation

dlesl
Copy link
Contributor

@dlesl dlesl commented May 11, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Notes

erlang-ls and its dependencies depend on a few rebar3 plugins, but none of them seem to be necessary to build it so I didn't include them.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122646 at bbc01c2b run on x86_64-linux 1

1 package built successfully:
  • erlang-ls
4 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/beam-modules/erlang-ls/default.nix:28:3:

       |
    28 |   meta = {
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/beam-modules/erlang-ls/default.nix:23:3:

       |
    23 |   installPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/beam-modules/erlang-ls/default.nix:16:3:

       |
    16 |   buildPhase = ''
       |   ^
    
  • warning: name-and-version

    Did you mean to pass pname instead of name to mkDerivation?

    Near pkgs/development/beam-modules/erlang-ls/default.nix:9:3:

      |
    9 |   name = "erlang-ls";
      |   ^
    

    Near pkgs/development/beam-modules/erlang-ls/default.nix:8:10:

      |
    8 |   inherit version;
      |          ^
    

@happysalada
Copy link
Contributor

I don't have any problems, I'm running the tests on darwin.
I'll wait a bit in case other people want to comment on this.
(In my opinion it's ready to merge).

@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 122646 run on x86_64-darwin 1

1 package built:
  • erlang-ls

@dlesl dlesl force-pushed the erlang-ls-init branch from f3e6f54 to a451d1e Compare May 12, 2021 15:31
@berbiche berbiche mentioned this pull request May 12, 2021
@happysalada happysalada merged commit 32c1466 into NixOS:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants