Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.05] python3Packages.xgboost: fix tests for darwin #124527

Merged
merged 1 commit into from
May 27, 2021
Merged

[21.05] python3Packages.xgboost: fix tests for darwin #124527

merged 1 commit into from
May 27, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 26, 2021 •
edited
Loading

Motivation for this change

ZHF #122042

Backport of #124437

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@risicle risicle requested review from FRidh and jonringer as code owners May 26, 2021 18:25
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 26, 2021
@ofborg ofborg bot requested a review from abbradar May 26, 2021 18:37
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 26, 2021
@SuperSandro2000 SuperSandro2000 merged commit 83fb69d into NixOS:release-21.05 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@risicle @SuperSandro2000