nix-direnv: make flakes support optional and off by default #126137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrworth
changed the title
lrworth
changed the title
`nix-direnv` depends on `nixUnstable` for flakes support, but that causes it to print a warning unless your user is trusted or the `experimental-features` setting is enabled. Neither of these are desirable (note that setting `experimental-features` in nix.conf causes warnings on `nixStable`). Since flakes are experimental, this commit makes `nixStable` the default and optionally allows `nixUnstable` with a new flag `enableFlakes`, prioritising a good experience for users not using experimental features.
lrworth
force-pushed
the
nix-direnv-configurable-flakes
branch
from
0cc32e3 to
03310df
Compare
|
Successfully created backport PR #126176 for |
|
The process '/usr/bin/git' failed with exit code 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Resolves nix-community/nix-direnv#89. nix-direnv depends on nixUnstable for flakes support, but that causes it to print a warning unless your user is trusted or the
experimental-featuressetting is enabled. Neither of these are desirable (note that settingexperimental-featuresin nix.conf causes warnings on nixStable).Since flakes are experimental, this PR makes the default
nixStableand optionally allowsnixUnstablewith a new flagenableFlakes, prioritising a good experience for users not using experimental features.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)