use sqlalchemy 1.3.x for mautrix-telegram #127486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ofborg
bot
added
8.has: package (new)
|
Result of 24 packages marked as broken and skipped:
1 package failed to build:1283 packages skipped due to time constraints:
127 packages built successfully:
7 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 61 packages marked as broken and skipped:
4 packages failed to build:1169 packages skipped due to time constraints:
122 packages built successfully:
7 suggestions:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
|
This was not supposed to change the default version. Fixed that. |
SuperSandro2000
requested changes
Jun 20, 2021
Comment on lines
+8125
to
+8126
| sqlalchemy_1_4 = callPackage ../development/python-modules/sqlalchemy/1.4.nix { }; | ||
| sqlalchemy = self.sqlalchemy_1_4; |
There was a problem hiding this comment.
Suggested change
| sqlalchemy_1_4 = callPackage ../development/python-modules/sqlalchemy/1.4.nix { }; | |
| sqlalchemy = self.sqlalchemy_1_4; | |
| sqlalchemy = callPackage ../development/python-modules/sqlalchemy { }; |
There was a problem hiding this comment.
sqlalchemy/default.nix doesn't exist anymore, so this would break evaluation.
Ma27
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The author seems to have no intentions of upgrading (source: mautrix/python#46).
If they remove the feature that needs sqlalchemy, we can remove the 1.3.x version.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)