Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 7.76.1 -> 7.79.1 #141829

Merged
merged 2 commits into from
Oct 17, 2021
Merged

curl: 7.76.1 -> 7.79.1 #141829

merged 2 commits into from
Oct 17, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 16, 2021 •
edited
Loading

Motivation for this change

My solution to the sticky situation in #124502

So far I've only built the early-stage curl on darwin. Will take a bit longer before my machine's managed the final curl. In the meantime I invite everyone possible to test it out so we might get this into the release.

Can't guarantee @mweinelt 's commit I pinched still catches all cases.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Oct 16, 2021
@mweinelt mweinelt added 1.severity: security Issues which raise a security issue, or PRs that fix one and removed 6.topic: steam Steam game store/launcher (store.steampowered.com) labels Oct 16, 2021
@github-actions github-actions bot added the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Oct 16, 2021
risicle and others added 2 commits October 16, 2021 11:35
@risicle
curl: 7.76.1 -> 7.79.1
106e944 
patching out SystemConfiguration requirement on darwin as we
can't use it from within the curl bootstrap loop
@mweinelt @risicle
curl: use --with/without-openssl instead of --with/without-ssl
f651d61 
This also migrates sslSupport to opensslSupport, which affects packages
overriding the curl package in that regard.
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Oct 16, 2021
@risicle risicle marked this pull request as ready for review October 16, 2021 13:59
@risicle risicle removed the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Oct 16, 2021
@mweinelt
Copy link
Member

Can't guarantee @mweinelt 's commit I pinched still catches all cases.

Still looking good.

mweinelt
mweinelt approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on x86_64-linux and aarch64-linux.

@github-actions github-actions bot added the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Oct 16, 2021
@mweinelt mweinelt merged commit ab19453 into NixOS:staging Oct 17, 2021
@lheckemann lheckemann mentioned this pull request Oct 20, 2021
Closed
9 tasks
@veprbl veprbl mentioned this pull request Oct 29, 2021
Closed
2 tasks
@FliegendeWurst FliegendeWurst mentioned this pull request Jan 25, 2022
Closed
2 tasks
This was referenced Jan 25, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@gleber gleber Awaiting requested review from gleber

@emanueleperuffo emanueleperuffo Awaiting requested review from emanueleperuffo

@np np Awaiting requested review from np

@lovek323 lovek323 Awaiting requested review from lovek323

@felschr felschr Awaiting requested review from felschr

@edolstra edolstra Awaiting requested review from edolstra

@evanjs evanjs Awaiting requested review from evanjs

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: steam Steam game store/launcher (store.steampowered.com) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@risicle @mweinelt @SuperSandro2000