-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/proxmox-image: init #144013
nixos/proxmox-image: init #144013
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't do much of a review because I've never used proxmox, but I left some comments regarding the Nix code.
f53b67a
to
e689453
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more nitpicks, sorry ;)
Add module to generate KVM templates that proxmox can import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a last thing, I'll ask you to wrap those couple of very long lines: there's no rule like 80 chars, but please limit it to at least something that doesn't overflow the github interface.
Otherwise the PR looks good to me, but I have no means of testing the image. Ideally someone else familiar with proxmox should review this.
I don't know any PVE+Nix users that haven't already worked with me on this... I've asked for help on discourse, let's see if anyone shows up in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like long lines but they should not overflow the GitHub UI.
Eventually I and more likely @astro are going to try it with our spaces proxmox cluster but that could take a bit. |
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
I was travelling over the weekend, so I could only merge suggestions from the github interface. I was planning to fix the whitespace and update the PR today. Thanks! |
Super nice, thanks @illustris ! |
Add module to generate KVM templates that proxmox can import.
Motivation for this change
Spinning up NixOS VMs on proxmox is a manual process at the moment. This module adds a way to generate VMA files that can be used as VM templates on proxmox.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)