Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.pop-shell: init #147542

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

genofire
Copy link
Contributor

@genofire genofire commented Nov 26, 2021

Motivation for this change

solve #104160, #102150 and a part of #144411

thanks @Enzime - sorry i could not wait and publish this part already in this PR.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 26, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 26, 2021
Copy link
Member

@piegamesde piegamesde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't judge for the patch in detail, but looks rather sane to me.

pkgs/desktops/gnome/extensions/pop-shell/default.nix Outdated Show resolved Hide resolved
@genofire
Copy link
Contributor Author

genofire commented Dec 1, 2021

It is the same, just with current commit id / rev -> i could not wait, till one of the other one is maintained (and merged).

@jsravn
Copy link
Contributor

jsravn commented Dec 17, 2021

Thanks for this! Testing it out, it all seems to work, however the default keybindings seem to be missing for a bunch of things (like super-m for maximize). Seems like scripts/configure.sh needs to be run as well, or something like it.

@trevex
Copy link

trevex commented Jul 9, 2022

@jsravn I set them up manually using home-manager's dconf module (they also include some tweaks):
https://github.com/trevex/dotfiles/blob/5b3b0e2b9624fbedd1a64d378e18aea6efef6db9/modules/nixos/desktop/gnome/default.nix#L60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants