npm2nix: 6.0.0 #15045
npm2nix: 6.0.0 #15045
Conversation
|
@gilligan yes, you modified pkgs/top-level/default.nix which I don't think you want to do. |
|
Otherwise 👍 |
|
@puffnfresh eeek. I screwed up somehow.. fix incoming shortly haha :) |
|
Not sure about these diff stats: |
gilligan
force-pushed
the
npm2nix-package
branch
from
981fca1 to
27937a8
Compare
|
Sorry everyone.. i somehow accidentally replaced the entire |
gilligan
force-pushed
the
npm2nix-package
branch
from
27937a8 to
23b23fe
Compare
| inherit (python3Packages) python; | ||
| inherit (purePackages) gl; | ||
| }; | ||
|
|
There was a problem hiding this comment.
can you drop these whitespace changes ? not against it but they are unrelated to the PR
|
Does npm2nix itself need to be inspected as well ? According to our conventions I think the commit should be named |
gilligan
force-pushed
the
npm2nix-package
branch
from
23b23fe to
4cba107
Compare
I am hoping to hear from @svanderburg that he is OK with this. |
| description = "Generate nix expressions to build npm packages"; | ||
| homepage = http://github.com/svanderburg/npm2nix/tree/reengineering2; | ||
| platforms = with platforms; linux ++ darwin; | ||
| }; |
There was a problem hiding this comment.
add yourself perhaps as maintainer?
gilligan
force-pushed
the
npm2nix-package
branch
from
4cba107 to
1dea211
Compare
| @@ -2195,7 +2195,9 @@ in | |||
| else | |||
| nodePackages_4_x; | |||
|
|
|||
| npm2nix = nodePackages.npm2nix; | |||
| npm2nix = callPackage ../development/tools/npm2nix { | |||
| inherit fetchFromGitHub; | |||
There was a problem hiding this comment.
Is inherit actually required here? I'd think callPackage would be able to fill it in.
|
There's this alternative deterministic package manager for nodejs called ied https://github.com/alexanderGugel/ied that took ideas explicitly from nix, that would be really simple to generate nix expressions from. I would suggest to rather make a simple solution based on ied, as continue to have complex solution as is now. And as far as i looked, it's doable, but of course somebody has to do it. |
|
ied is not even close to be feature complete and thus sadly not a feasible replacement for now - plus considerable effort has been invested into npm2nix which is a working solution which shouldn't just be discarded. My 2 cents ;) |
|
@gilligan what is the license of npm2nix ? I see a warning emitted by npm that the field is missing. |
|
|
|
@zimbatm I think travis uses unsandboxed builds. |
|
@gilligan @svanderburg is this PR obsolete? |
|
Oh, yes indeed |
This is a first PR to work towards what was discussed in #14532
The reengineering branch by @svanderburg is a big improvement on
NixOS/npm2nixversion. I hope you are fine with me packaging it./cc @zimbatm
Edit: I first tried to actually remove npm2nix from node-packages.json / node-packages-generated not realizing that the new npm2nix version generates output that is not compatible with the previous one. I amended it to only add the package for now.