-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autoconf-2.13 #156656
fix: autoconf-2.13 #156656
Conversation
Result of 1 package built:
|
This should go into staging. |
I will squash-merge this to make it one single commit with a commit message following nixpkgs manual. |
Thanks for raising this @luochen1990 |
Can xz be removed as a dependency altogether? |
@siraben I tried to remove xz and it build successfully, but I'm not sure whether there is any different with the output. |
I did the same test. xz is unused during the build and there is no reference to xz or lzma in all the binaries/scripts it produces. I made a PR to remove it (linked above). |
Motivation for this change
Find a typo.
Things done
Fixed the typo from
nativebuildInputs
intonativeBuildInputs
, but it also works withoutnativeBuildInputs = [ xz ];
, so we might delete this dependency as well.sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes