-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet-sdk: 6.0.201 -> 6.0.202 #168486
dotnet-sdk: 6.0.201 -> 6.0.202 #168486
Conversation
fc20ea1
to
c4f6d3b
Compare
|
b00157b
to
2747d8a
Compare
7c94b58
to
2f4e053
Compare
On darwin-aarch64,
|
Hmm, |
Very possibly! Feel free not to consider this blocking.
-------- Original Message --------
…On 23 Apr 2022, 12:16, mdarocha wrote:
> On darwin-aarch64, mono twice failed to build under nix run nixpkgs#nixpkgs-review pr #168486, but I don't yet know whether this is true on master. (And I'm going to bed now.)
>
> /nix/store/cmcl1jichs33ynwv5apzs8r8ndx2w2pi-bash-5.1-p16/bin/bash ../mkinstalldirs _tmpinst/bin
> mkdir -p -- _tmpinst/bin
> cp mono-wrapper _tmpinst/bin/mono
> echo '#! /bin/sh' > _tmpinst/bin/ilasm ; \
> r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
> echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/ilasm/ilasm.exe"'" "$@"' >> _tmpinst/bin/ilasm ; \
> chmod +x _tmpinst/bin/ilasm
> echo '#! /bin/sh' > _tmpinst/bin/csc ; \
> r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
> echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"/private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/external/roslyn-binaries/Microsoft.Net.Compilers/3.6.0/csc.exe"'" "$@"' >> _tmpinst/bin/csc ; \
> chmod +x _tmpinst/bin/csc
> echo '#! /bin/sh' > _tmpinst/bin/mcs ; \
> r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
> echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/class/lib/net_4_x/mcs.exe"'" "$@"' >> _tmpinst/bin/mcs ; \
> chmod +x _tmpinst/bin/mcs
> echo '#! /bin/sh' > _tmpinst/bin/al ; \
> r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
> echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/class/lib/net_4_x/al.exe"'" "$@"' >> _tmpinst/bin/al ; \
> chmod +x _tmpinst/bin/al
> if test -w /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs; then :; else chmod -R +w /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs; fi
> cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && make --no-print-directory -s NO_DIR_CHECK=1 PROFILES='binary_reference_assemblies net_4_x xbuild_12 xbuild_14 ' CC='clang' all-profiles
> mkdir -p -- build/deps
> /nix/store/cmcl1jichs33ynwv5apzs8r8ndx2w2pi-bash-5.1-p16/bin/bash: line 1: mono: command not found
> make[6]: *** [build/profiles/build.make:134: build/deps/basic-profile-check.exe] Error 127
> *** The runtime 'mono' doesn't appear to be usable.
> *** Trying the 'monolite-macos/1A5E0066-58DC-428A-B21C-0AD6CDAE2789' directory.
> make[8]: *** [build/profiles/build.make:134: build/deps/basic-profile-check.exe] Segmentation fault: 11
> *** The contents of your 'monolite-macos/1A5E0066-58DC-428A-B21C-0AD6CDAE2789' directory may be out-of-date
> *** You may want to try 'make get-monolite-latest'
> make[8]: *** [build/profiles/build.make:117: do-profile-check-monolite] Error 1
> make[7]: *** [build/profiles/build.make:93: do-profile-check] Error 2
> make[6]: *** [build/profiles/build.make:129: do-profile-check-monolite] Error 2
> make[5]: *** [build/profiles/build.make:93: do-profile-check] Error 2
Hmm, mono should not be affected by these changes. I can't test this, since I have no access to Apple hardware, but the CI builds seem to have passed fine. Isn't it some issue with your local configuration?
—
Reply to this email directly, [view it on GitHub](#168486 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAX6DVPBGJEZZ2PDW7D3N63VGPLZVANCNFSM5TKTJ7HQ).
You are receiving this because you commented.Message ID: ***@***.***>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package blacklisted:
1 package failed to build and are new build failure:
15 packages built:
|
2f4e053
to
5f44196
Compare
Use the currently checked out nixpkgs, not the system one. Also add a CLI flag to not update the app, but dependencies only.
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package blacklisted:
1 package failed to build and are new build failure:
15 packages built:
|
I am still getting the following error for osu-lazer:
|
Hmm, theres not much I can do about this error. Dotnet on *unixes still has the limitation from Windows that only one process can access each file. This can cause errors like this to crop up randomly. I encountered it while building another package, and retrying the build fixed it for me. You can also check if there aren't any other dotnet processes that may block the file. |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package blacklisted:
16 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, seems to be flakey. Anyway, it builds and LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you :)
Result of nixpkgs-review pr 168486
run on x86_64-linux 1
1 package blacklisted:
- tests.writers
16 packages built:
- ArchiSteamFarm
- btcpayserver
- discordchatexporter-cli
- dotnet-aspnetcore (dotnetCorePackages.aspnetcore_6_0)
- dotnet-runtime (dotnetCorePackages.runtime_6_0)
- dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
- github-runner
- inklecate
- jackett
- nbxplorer
- omnisharp-roslyn
- opentabletdriver
- osu-lazer
- pinta
- pre-commit
- ryujinx
This broke Archisteamfarm for aarch64-linux: https://hydra.nixos.org/build/176111899 See also ofborg checks on this PR. ZHF: #172160 |
Fixed in #172589 |
Description of changes
https://devblogs.microsoft.com/dotnet/april-2022-updates/
This update, among other things, fixes
dotnet format
, which was broken in 6.0.200.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes