Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-sdk: 6.0.201 -> 6.0.202 #168486

Merged
merged 8 commits into from
Apr 25, 2022

Conversation

mdarocha
Copy link
Contributor

@mdarocha mdarocha commented Apr 13, 2022

Description of changes

https://devblogs.microsoft.com/dotnet/april-2022-updates/

This update, among other things, fixes dotnet format, which was broken in 6.0.200.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mdarocha
Copy link
Contributor Author

mdarocha commented Apr 13, 2022

TODO - these packages fail on x86_64-linux after updating - seems like they need updated dependencies:

  • ArchiSteamFarm
  • github-runner
  • inklecate
  • omnisharp-roslyn
  • ryujinx

@mdarocha mdarocha force-pushed the dotnet-6.0.4-update branch from b00157b to 2747d8a Compare April 13, 2022 14:39
@mdarocha mdarocha marked this pull request as ready for review April 13, 2022 14:44
@mdarocha mdarocha force-pushed the dotnet-6.0.4-update branch from 7c94b58 to 2f4e053 Compare April 17, 2022 13:35
@Smaug123
Copy link
Contributor

Smaug123 commented Apr 18, 2022

On darwin-aarch64, mono twice failed to build under nix run nixpkgs#nixpkgs-review pr https://github.com/NixOS/nixpkgs/pull/168486, but I don't yet know whether this is true on master. (And I'm going to bed now.)

/nix/store/cmcl1jichs33ynwv5apzs8r8ndx2w2pi-bash-5.1-p16/bin/bash ../mkinstalldirs _tmpinst/bin
mkdir -p -- _tmpinst/bin
cp mono-wrapper _tmpinst/bin/mono
echo '#! /bin/sh' > _tmpinst/bin/ilasm ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/ilasm/ilasm.exe"'" "$@"' >> _tmpinst/bin/ilasm ; \
chmod +x _tmpinst/bin/ilasm
echo '#! /bin/sh' > _tmpinst/bin/csc ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"/private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/external/roslyn-binaries/Microsoft.Net.Compilers/3.6.0/csc.exe"'" "$@"' >> _tmpinst/bin/csc ; \
chmod +x _tmpinst/bin/csc
echo '#! /bin/sh' > _tmpinst/bin/mcs ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/class/lib/net_4_x/mcs.exe"'" "$@"' >> _tmpinst/bin/mcs ; \
chmod +x _tmpinst/bin/mcs
echo '#! /bin/sh' > _tmpinst/bin/al ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/class/lib/net_4_x/al.exe"'" "$@"' >> _tmpinst/bin/al ; \
chmod +x _tmpinst/bin/al
if test -w /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs; then :; else chmod -R +w /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs; fi
cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && make --no-print-directory -s NO_DIR_CHECK=1 PROFILES='binary_reference_assemblies net_4_x xbuild_12 xbuild_14              ' CC='clang' all-profiles
mkdir -p -- build/deps
/nix/store/cmcl1jichs33ynwv5apzs8r8ndx2w2pi-bash-5.1-p16/bin/bash: line 1: mono: command not found
make[6]: *** [build/profiles/build.make:134: build/deps/basic-profile-check.exe] Error 127
*** The runtime 'mono' doesn't appear to be usable.
*** Trying the 'monolite-macos/1A5E0066-58DC-428A-B21C-0AD6CDAE2789' directory.
make[8]: *** [build/profiles/build.make:134: build/deps/basic-profile-check.exe] Segmentation fault: 11
*** The contents of your 'monolite-macos/1A5E0066-58DC-428A-B21C-0AD6CDAE2789' directory may be out-of-date
*** You may want to try 'make get-monolite-latest'
make[8]: *** [build/profiles/build.make:117: do-profile-check-monolite] Error 1
make[7]: *** [build/profiles/build.make:93: do-profile-check] Error 2
make[6]: *** [build/profiles/build.make:129: do-profile-check-monolite] Error 2
make[5]: *** [build/profiles/build.make:93: do-profile-check] Error 2

@mdarocha
Copy link
Contributor Author

On darwin-aarch64, mono twice failed to build under nix run nixpkgs#nixpkgs-review pr https://github.com/NixOS/nixpkgs/pull/168486, but I don't yet know whether this is true on master. (And I'm going to bed now.)

/nix/store/cmcl1jichs33ynwv5apzs8r8ndx2w2pi-bash-5.1-p16/bin/bash ../mkinstalldirs _tmpinst/bin
mkdir -p -- _tmpinst/bin
cp mono-wrapper _tmpinst/bin/mono
echo '#! /bin/sh' > _tmpinst/bin/ilasm ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/ilasm/ilasm.exe"'" "$@"' >> _tmpinst/bin/ilasm ; \
chmod +x _tmpinst/bin/ilasm
echo '#! /bin/sh' > _tmpinst/bin/csc ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"/private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/external/roslyn-binaries/Microsoft.Net.Compilers/3.6.0/csc.exe"'" "$@"' >> _tmpinst/bin/csc ; \
chmod +x _tmpinst/bin/csc
echo '#! /bin/sh' > _tmpinst/bin/mcs ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/class/lib/net_4_x/mcs.exe"'" "$@"' >> _tmpinst/bin/mcs ; \
chmod +x _tmpinst/bin/mcs
echo '#! /bin/sh' > _tmpinst/bin/al ; \
r=`pwd`; m=`cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && pwd`; \
echo 'exec "'"$r/_tmpinst/bin/mono"'" "'"$m/class/lib/net_4_x/al.exe"'" "$@"' >> _tmpinst/bin/al ; \
chmod +x _tmpinst/bin/al
if test -w /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs; then :; else chmod -R +w /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs; fi
cd /private/tmp/nix-build-mono-6.12.0.122.drv-1/mono-6.12.0.122/mcs && make --no-print-directory -s NO_DIR_CHECK=1 PROFILES='binary_reference_assemblies net_4_x xbuild_12 xbuild_14              ' CC='clang' all-profiles
mkdir -p -- build/deps
/nix/store/cmcl1jichs33ynwv5apzs8r8ndx2w2pi-bash-5.1-p16/bin/bash: line 1: mono: command not found
make[6]: *** [build/profiles/build.make:134: build/deps/basic-profile-check.exe] Error 127
*** The runtime 'mono' doesn't appear to be usable.
*** Trying the 'monolite-macos/1A5E0066-58DC-428A-B21C-0AD6CDAE2789' directory.
make[8]: *** [build/profiles/build.make:134: build/deps/basic-profile-check.exe] Segmentation fault: 11
*** The contents of your 'monolite-macos/1A5E0066-58DC-428A-B21C-0AD6CDAE2789' directory may be out-of-date
*** You may want to try 'make get-monolite-latest'
make[8]: *** [build/profiles/build.make:117: do-profile-check-monolite] Error 1
make[7]: *** [build/profiles/build.make:93: do-profile-check] Error 2
make[6]: *** [build/profiles/build.make:129: do-profile-check-monolite] Error 2
make[5]: *** [build/profiles/build.make:93: do-profile-check] Error 2

Hmm, mono should not be affected by these changes. I can't test this, since I have no access to Apple hardware, but the CI builds seem to have passed fine. Isn't it some issue with your local configuration?

@Smaug123
Copy link
Contributor

Smaug123 commented Apr 23, 2022 via email

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/822

@gador
Copy link
Member

gador commented Apr 24, 2022

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 168486 run on x86_64-linux 1

1 package blacklisted:
  • tests.writers
1 package failed to build and are new build failure:
  • osu-lazer: log was empty
15 packages built:
  • ArchiSteamFarm
  • btcpayserver
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnetCorePackages.aspnetcore_6_0)
  • dotnet-runtime (dotnetCorePackages.runtime_6_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • github-runner
  • inklecate
  • jackett
  • nbxplorer
  • omnisharp-roslyn
  • opentabletdriver
  • pinta
  • pre-commit
  • ryujinx

@mdarocha mdarocha force-pushed the dotnet-6.0.4-update branch from 2f4e053 to 5f44196 Compare April 25, 2022 05:51
Use the currently checked out nixpkgs, not the system one.
Also add a CLI flag to not update the app, but dependencies only.
@mdarocha
Copy link
Contributor Author

osu-lazer should be fixed now

@gador
Copy link
Member

gador commented Apr 25, 2022

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 168486 run on x86_64-linux 1

1 package blacklisted:
  • tests.writers
1 package failed to build and are new build failure:
  • osu-lazer: log was empty
15 packages built:
  • ArchiSteamFarm
  • btcpayserver
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnetCorePackages.aspnetcore_6_0)
  • dotnet-runtime (dotnetCorePackages.runtime_6_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • github-runner
  • inklecate
  • jackett
  • nbxplorer
  • omnisharp-roslyn
  • opentabletdriver
  • pinta
  • pre-commit
  • ryujinx

@gador
Copy link
Member

gador commented Apr 25, 2022

I am still getting the following error for osu-lazer:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/368w2xwqib74kpn650sm562ad3ifc094-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
Executing dotnetConfigureHook
  Determining projects to restore...
/nix/store/bbr88j9h3dmfg9147r3fha1zjdqj2v48-dotnet-sdk-6.0.202/sdk/6.0.202/NuGet.targets(564,5): error : The process cannot access the file '/build/tmp.QExyqLusF0/.nuget/NuGet/nugetorgadd.trk' because it is being used by another process. [/build/source/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj]

@mdarocha
Copy link
Contributor Author

mdarocha commented Apr 25, 2022

I am still getting the following error for osu-lazer:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/368w2xwqib74kpn650sm562ad3ifc094-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
Executing dotnetConfigureHook
  Determining projects to restore...
/nix/store/bbr88j9h3dmfg9147r3fha1zjdqj2v48-dotnet-sdk-6.0.202/sdk/6.0.202/NuGet.targets(564,5): error : The process cannot access the file '/build/tmp.QExyqLusF0/.nuget/NuGet/nugetorgadd.trk' because it is being used by another process. [/build/source/osu.Game.Rulesets.Catch/osu.Game.Rulesets.Catch.csproj]

Hmm, theres not much I can do about this error. Dotnet on *unixes still has the limitation from Windows that only one process can access each file. This can cause errors like this to crop up randomly. I encountered it while building another package, and retrying the build fixed it for me. You can also check if there aren't any other dotnet processes that may block the file.

@gador
Copy link
Member

gador commented Apr 25, 2022

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 168486 run on x86_64-linux 1

1 package blacklisted:
  • tests.writers
16 packages built:
  • ArchiSteamFarm
  • btcpayserver
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnetCorePackages.aspnetcore_6_0)
  • dotnet-runtime (dotnetCorePackages.runtime_6_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • github-runner
  • inklecate
  • jackett
  • nbxplorer
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pinta
  • pre-commit
  • ryujinx

Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, seems to be flakey. Anyway, it builds and LGTM!

Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you :)

Result of nixpkgs-review pr 168486 run on x86_64-linux 1

1 package blacklisted:
  • tests.writers
16 packages built:
  • ArchiSteamFarm
  • btcpayserver
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnetCorePackages.aspnetcore_6_0)
  • dotnet-runtime (dotnetCorePackages.runtime_6_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • github-runner
  • inklecate
  • jackett
  • nbxplorer
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pinta
  • pre-commit
  • ryujinx

@IvarWithoutBones IvarWithoutBones merged commit 88dd603 into NixOS:master Apr 25, 2022
@mdarocha mdarocha deleted the dotnet-6.0.4-update branch April 25, 2022 18:06
@Mindavi
Copy link
Contributor

Mindavi commented May 10, 2022

This broke Archisteamfarm for aarch64-linux: https://hydra.nixos.org/build/176111899

See also ofborg checks on this PR.

ZHF: #172160

@mdarocha
Copy link
Contributor Author

This broke Archisteamfarm for aarch64-linux: https://hydra.nixos.org/build/176111899

See also ofborg checks on this PR.

ZHF: #172160

Fixed in #172589

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants