Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omnisharp-roslyn: fix errors related to dlls #170296

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

mdarocha
Copy link
Contributor

@mdarocha mdarocha commented Apr 25, 2022

Description of changes

As described here: #166543 (comment)

Mimick the hack in the upstream omnisharp repository, which
fixes omnisharp giving errors about being unable to find
specific libraries

Closes #166543

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Mimick the hack in the upstream omnisharp repository, which
fixes omnisharp giving errors about being unable to find
specific libraries
@SuperSandro2000 SuperSandro2000 merged commit c7fd39a into NixOS:master Apr 26, 2022
@mdarocha mdarocha deleted the fix-omnisharp-errors branch June 25, 2022 14:12
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/dotnet-script-libhostfxr-so-not-found/22346/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

omnisharp can't find libhostfxr.so
5 participants