Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pressureaudio: remove autoreconfHook to fix build for ZHF #172167

Merged
merged 1 commit into from May 9, 2022
Merged

pressureaudio: remove autoreconfHook to fix build for ZHF #172167

merged 1 commit into from May 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2022

ZHF: #172160

Description of changes

pressureaudio's nix expression uses src = pulseaudio.src, so when pulseaudio switched over to meson an dropped autoreconfHook the same should have been done here as well.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

pressureaudio: remove autoreconfHook to fix build for ZHF
ce9122d 
pressureaudio's nix expression uses `src = pulseaudio.src`, so when
pulseaudio switched over to meson an dropped autoreconfHook the same
should have been done here as well.
@ofborg ofborg bot requested a review from jagajaga May 9, 2022 11:29
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 9, 2022
@ghost
Copy link
Author

ghost commented May 9, 2022

The ZHF announcement PR says: "Please ping @NixOS/nixos-release-managers on the PR and add the 0.kind: build failure label to the pull request. If you're unable to because you're not a member of the NixOS org please ping @dasJ, @tomberek, @jonringer, @Mic92"

I am unable to add this build label, so I therefore am issuing this ping.

@davidak davidak added the 0.kind: build failure A package fails to build label May 9, 2022
@davidak
Copy link
Member

davidak commented May 9, 2022

Result of nixpkgs-review pr 172167 run on x86_64-linux 1

1 package built:
  • libpressureaudio

davidak
davidak approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

Builds

(you don't need to add "for ZHF" to the commit message)

Thanks for your contribution!

@davidak davidak merged commit edce911 into NixOS:master May 9, 2022
@ghost ghost deleted the pr/fix-pressureaudio-build branch May 9, 2022 12:39
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidak