Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delve: remove restriction from platforms #177722

Merged
merged 2 commits into from
Jun 16, 2022
Merged

delve: remove restriction from platforms #177722

merged 2 commits into from
Jun 16, 2022

Conversation

karlskewes
Copy link
Contributor

@karlskewes karlskewes commented Jun 15, 2022 •
edited
Loading

Description of changes

Add AArch64 build target.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 15, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 15, 2022
misuzu
misuzu approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 177722 run on aarch64-linux 1

1 package built:
  • delve

@karlskewes
Copy link
Contributor Author

Trying to cross build from x86 but hitting this issue: #154163 (comment)

@ofborg ofborg bot requested a review from SuperSandro2000 June 15, 2022 18:33
@SuperSandro2000 SuperSandro2000 changed the title delve: Build for Linux AArch64|arm64 delve: remove restriction from platforms Jun 16, 2022
@SuperSandro2000 SuperSandro2000 merged commit 953d77f into NixOS:master Jun 16, 2022
@karlskewes karlskewes deleted the delve-linux-aarch64 branch June 18, 2022 06:59
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@vdemeester vdemeester Awaiting requested review from vdemeester

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlskewes @misuzu @SuperSandro2000 @Janik-Haag