Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb: fix darwin build #180620

Merged
merged 7 commits into from
Sep 11, 2022
Merged

mongodb: fix darwin build #180620

merged 7 commits into from
Sep 11, 2022

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Jul 8, 2022

Description of changes

I removed patch on Darwin because in failed with 2 of 2 hunk failed to apply (I haven't checked if they can be adapted because they were already no-op and nobody fixed those. I don't know how to setup sandbox = true I added in ~/.config/nix/nix.conf but nix-info still can't find it 🤷‍♂️.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 8, 2022
@Et7f3 Et7f3 force-pushed the fix-mongodb-darwin branch 2 times, most recently from aca4734 to c671cde Compare July 20, 2022 00:30
Et7f3 and others added 6 commits July 20, 2022 02:30
duplicate symbol 'mongo::error_details::isNamedCode<100>' in:
    build/nixos/mongo/libmongodmain.a(db.o)
    build/nixos/third_party/murmurhash3/libmurmurhash3.a(MurmurHash3.o)
duplicate symbol 'mongo::error_details::isNamedCode<11000>' in:
    build/nixos/mongo/libmongodmain.a(db.o)
    build/nixos/third_party/murmurhash3/libmurmurhash3.a(MurmurHash3.o)
ld: 380094 duplicate symbols for architecture x86_64
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
scons: *** [build/nixos/mongo/mongod] Error 1
scons: building terminated because of errors.
build/nixos/mongo/mongo failed: Error 1
build/nixos/mongo/mongos failed: Error 1
build/nixos/mongo/mongod failed: Error 1
gcc 11 doesn't add <optional> by mistake.
@Et7f3 Et7f3 force-pushed the fix-mongodb-darwin branch from f34ea8c to e7d158d Compare July 21, 2022 23:35
@Et7f3
Copy link
Contributor Author

Et7f3 commented Sep 11, 2022

Ping @bryanasdev000

@domenkozar domenkozar merged commit 27eb752 into NixOS:master Sep 11, 2022
@Et7f3 Et7f3 deleted the fix-mongodb-darwin branch September 11, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants