Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel_5: get libtool from path #183917

Merged
merged 1 commit into from
Jul 31, 2022
Merged

bazel_5: get libtool from path #183917

merged 1 commit into from
Jul 31, 2022

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Jul 30, 2022 •
edited
Loading

Description of changes

We're resolving most cc toolchain tools from the path and environment variables, but we hardcode libtool. This makes it hard to point libtool to the specific one you need, for example to work around issues like #180251 (comment). Make it consistent by getting libtool from path too, like other cc toolchain tools.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@uri-canva uri-canva requested a review from Profpatsch as a code owner July 30, 2022 07:31
@uri-canva
bazel_5: get libtool from path
75d6a6a 
We're resolving most cc toolchain tools from the path and environment variables, but we hardcode libtool. This makes it hard to point libtool to the specific one you need, for example to work around issues like
NixOS#180251 (comment). Make it consistent by getting libtool from path too, like other cc toolchain tools.
@uri-canva uri-canva mentioned this pull request Jul 30, 2022
Merged
13 tasks
@uri-canva
Copy link
Contributor Author

@ofborg build python3packages.jaxlib

@uri-canva
Copy link
Contributor Author

@ofborg build python3Packages.jaxlib

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 30, 2022
avdv
avdv approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jul 30, 2022
@uri-canva
Copy link
Contributor Author

Sent upstream too: bazelbuild/bazel#16010, bazelbuild/rules_cc#135.

@uri-canva uri-canva merged commit e30abcd into NixOS:master Jul 31, 2022
@uri-canva uri-canva deleted the bazel-libtool branch July 31, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdv avdv avdv approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@aherrmann aherrmann Awaiting requested review from aherrmann

@olebedev olebedev Awaiting requested review from olebedev

@marsam marsam Awaiting requested review from marsam

@groodt groodt Awaiting requested review from groodt

@ylecornec ylecornec Awaiting requested review from ylecornec

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uri-canva @avdv @bobby285271