pkgsMusl.colord: enable the daemon #187121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since f95d9a6 ("pkgsMusl.polkit: fix build"), pkgsMusl.polkit builds, which means the colord daemon can also build in pkgsMusl.
ofborg
bot
added
10.rebuild-darwin: 0
|
Does pkgsStatic.colord also build successfully with the daemon enabled? |
Pretty sure it always did, because I didn't disable it there. But let's see! @ofborg build pkgsStatic.colord |
|
Oh right, |
| @@ -26,7 +26,7 @@ | |||
| , docbook_xml_dtd_412 | |||
| , gtk-doc | |||
| , libxslt | |||
| , enableDaemon ? !stdenv.hostPlatform.isMusl || stdenv.hostPlatform.isStatic | |||
| , enableDaemon ? true | |||
There was a problem hiding this comment.
The option only got added for musl so we could remove it again 46339db
There was a problem hiding this comment.
We could, but it's not hurting anything to leave it in, and it would be useful for e.g. closure size reduction.
There was a problem hiding this comment.
I am just a bit worried about it bit rotting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since f95d9a6 ("pkgsMusl.polkit: fix build"), pkgsMusl.polkit builds, which means the colord daemon can also build in pkgsMusl.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes