-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: specify that longDescription
should be Markdown
#188805
Conversation
Please reference RFC72 in the commit message so we have a paper trail for the reasoning behind the change. |
5162793
to
f2b012d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should link to the nixpkgs chapter of markdown extensions instead, but using plain commonmark for long descriptions also also perfectly fine.
doc/stdenv/meta.chapter.md
Outdated
@@ -80,7 +80,7 @@ Right: `"A library for decoding PNG images"` | |||
|
|||
### `longDescription` {#var-meta-longDescription} | |||
|
|||
An arbitrarily long description of the package. | |||
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown format. | |
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown. |
Either use this suggestion, or add "the".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or to follow pennae's suggestion: Nixpkgs Markdown.
In the spirit of RFC 72, document that longDescription is in CommonMark.
f2b012d
to
2f88279
Compare
I don't think we want to use any extensions in package descriptions, so CommonMark should be fine. |
Yes, currently it is plain text. |
@@ -80,7 +80,7 @@ Right: `"A library for decoding PNG images"` | |||
|
|||
### `longDescription` {#var-meta-longDescription} | |||
|
|||
An arbitrarily long description of the package. | |||
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown. | |
An arbitrarily long description of the package in [CommonMark Markdown](https://commonmark.org). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes it look too much like there is a thing called CommonMark Markdown, maybe use something like the following instead:
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown. | |
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown dialect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtojnar in that case, add "the".
An arbitrarily long description of the package in [CommonMark](https://commonmark.org) Markdown. | |
An arbitrarily long description of the package in the [CommonMark](https://commonmark.org) Markdown dialect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My latest suggestion was 50% ironic and this is 100% my last suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the sentence is fine as it is and the bikeshed will stay purple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, no, no, the bikeshed must be blue. Anything else is ridiculous.
See NixOS/nixos-search#525 for context.
In the spirit of RFC 72, document that
longDescription
is in Markdown format (should this be CommonMark?).This is purely a documentation change because I don't think there are currently any consumers of
longDescription
that rely on it being a particular format besides plain text.Producers, on the other hand, seem to have been using the Markdown convention, if any.