Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networking: enable "multi on" in resolver settings #19185

Merged
merged 1 commit into from
Oct 3, 2016

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 3, 2016

Motivation for this change

this allows to return ipv4/ipv6 addresses for the same host in /etc/hosts.
fixes #19148

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ardumont, @edolstra and @wkennington to be potential reviewers.

this allows to return ipv4/ipv6 addresses for the same host in /etc/hosts.
fixes NixOS#19148
@Mic92 Mic92 merged commit 3dbecd4 into NixOS:master Oct 3, 2016
@Mic92 Mic92 deleted the networking branch October 3, 2016 14:51
@nhooyr
Copy link
Contributor

nhooyr commented Oct 3, 2016

We're also missing the manpage for host.conf(5) so we should add that.

@Mic92
Copy link
Member Author

Mic92 commented Oct 3, 2016

I have this manpage on nixos unstable. I have manpages in system-packages.

@vcunat
Copy link
Member

vcunat commented Oct 3, 2016

@nhooyr: how so? Our standard man-pages package does contain it.

@bennofs
Copy link
Contributor

bennofs commented Oct 3, 2016

@nhooyr man host.conf works on my NixOS system:

$ man -w host.conf 
/nix/store/29x1w0qmbxkns17zzj2f6ldnc3xp2dl3-man-pages-4.07/share/man/man5/host.conf.5.gz

@nhooyr
Copy link
Contributor

nhooyr commented Oct 3, 2016

Ah sorry, I didn't have the man-pages package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glibc: getaddrinfo only returns ipv4 address for localhost even if ipv6 is enabled
5 participants