pcb: use xorg.* packages directly instead of xlibsWrapper #194691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recommended by #194054 Built outputs (`x86-linux`) are identical except for the `pcb` binary, which was manually reviewed with `vbindiff` to confirm that the only differences were self-$out path references.
ofborg
bot
added
10.rebuild-darwin: 0
83 tasks
trofi
approved these changes
Oct 8, 2022
bobby285271
added
the
12.approvals: 1
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As recommended by #194054
Built outputs (
x86-linux) are identical except for thepcbbinary, which was manually reviewed withvbindiffto confirm that the only differences were self-$out path references.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)