-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonManylinuxPackages: add libz and expat #196802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the diff looks fine but the build throws errors:
nix-build -A pythonManylinuxPackages
error:
… while calling the 'foldl'' builtin
at /home/janik/Projects/nixos/nixpkgs/pkgs/development/interpreters/python/manylinux/default.nix:78:16:
77| # Additionally, add `autoPatchelfHook` to `nativeBuildInputs`.
78| manylinux1 = lib.unique (lib.attrValues manylinux1Libs);
| ^
79| manylinux2010 = lib.unique (lib.attrValues manylinux2010Libs);
… while evaluating a branch condition
at /home/janik/Projects/nixos/nixpkgs/lib/lists.nix:646:28:
645| */
646| unique = foldl' (acc: e: if elem e acc then acc else acc ++ [ e ]) [];
| ^
647|
(stack trace truncated; use '--show-trace' to show the full trace)
error: undefined variable 'libz'
at /home/janik/Projects/nixos/nixpkgs/pkgs/development/interpreters/python/manylinux/default.nix:59:19:
58| "libglib-2.0.so.0" = glib;
59| "libz.so.1" = libz;
| ^
60| "libexpat.so.1" = expat;
``` :/
These libs aren't mentioned in PEP 513, but auditwheel allows them (pypa/auditwheel#152) and so built wheels may depend on them.
Thanks for checking, and sorry for the mistake. (I could have sworn I ran Anyway, it should be better now. |
Thanks for your contribution and sorry that It took so long until someone reviewed it /: |
Description of changes
Adds two libs to the
pythonManylinuxPackages
collection. These libs aren't mentioned in PEP 513, but auditwheel allows them (pypa/auditwheel#152) and so built wheels may depend on them.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes