-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discord: add a script to disable breaking updates #197248
discord: add a script to disable breaking updates #197248
Conversation
14166e7
to
c223efc
Compare
i don't know if the script will work on darwin |
At a glance, this looks good to me, but testing it is slightly annoying so I haven't done that yet. |
To test check the settings.json ex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, I was getting really tired of discord self-destructing so frequently when they push updates.
I was more so referring to testing that older host versions then run properly, however yeah that should be good enough. |
# verify that there's no SKIP_HOST_UPDATE in settings.json and if there is then remove it and the last ','
# 7b38cb118ce is one commit before discord-canary: 0.0.139 -> 0.0.140
NIXPKGS_ALLOW_UNFREE=1 nix run "github:nixos/nixpkgs/7b38cb118ce#discord-canary" --impure
# observe that discord cannot start
NIXPKGS_ALLOW_UNFREE=1 nix run --impure "github:Artturin/nixpkgs/discord-disable-breaking-updates#discord-canary.disableBreakingUpdates"
NIXPKGS_ALLOW_UNFREE=1 nix run "github:nixos/nixpkgs/7b38cb118ce#discord-canary" --impure
# observe that discord starts |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-22.05
git worktree add -d .worktree/backport-197248-to-release-22.05 origin/release-22.05
cd .worktree/backport-197248-to-release-22.05
git checkout -b backport-197248-to-release-22.05
ancref=$(git merge-base 4752722090be8e7fd4ecceb12bee492851837d3d c223efc36b39e4b88a5ac4f79dcb95881ed58d18)
git cherry-pick -x $ancref..c223efc36b39e4b88a5ac4f79dcb95881ed58d18 |
backport #197266 |
Check the docstring
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes