Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbin: init at 0.1.4 #200195

Merged
merged 1 commit into from
Dec 7, 2022
Merged

bbin: init at 0.1.4 #200195

merged 1 commit into from
Dec 7, 2022

Conversation

Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Nov 8, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

pkgs/development/tools/bbin/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/bbin/default.nix Show resolved Hide resolved
pkgs/development/tools/bbin/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/bbin/default.nix Show resolved Hide resolved
pkgs/development/tools/bbin/default.nix Show resolved Hide resolved
pkgs/development/tools/bbin/default.nix Show resolved Hide resolved
@Sohalt Sohalt force-pushed the bbin branch 2 times, most recently from 251a4f0 to 3951393 Compare November 8, 2022 20:15
@Sohalt Sohalt mentioned this pull request Nov 8, 2022
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

pkgs/development/tools/bbin/default.nix Outdated Show resolved Hide resolved
@Sohalt
Copy link
Contributor Author

Sohalt commented Nov 11, 2022

Thanks @AndersonTorres for the review! I addressed all your points.
However I currently get

24:   ["bb" "--deps-root" script-root "--config" (str tmp-edn)
25:         script-main-opts-first script-main-opts-second
26:         "--"])
27: 
28: (process/exec (into base-command *command-line-args*))
    ^--- exec is not supported in non-GraalVM environments

when trying to execute a script installed with bbin.
Not entirely sure what's going on there, since babashka is using GraalVM.
Maybe some of the babashka maintainers know more? cc @BAndresen @bhougland @DerGuteMoritz @jlesquembre @thiagokokada

@Sohalt Sohalt marked this pull request as draft November 11, 2022 13:08
@Sohalt
Copy link
Contributor Author

Sohalt commented Nov 11, 2022

Ok, the issue is that the check for whether process/exec is supported, happens at compile time and nixpkgs uses the babashka-standalone.jar from the babashka-releases, which used to be built with AdoptOpenJDK (it's built with GraalVM since babashka/babashka@a5dec07). So this should work without changes to this PR as soon as the next version gets released and packaged for nixpkgs.

@AndersonTorres
Copy link
Member

So you need a new babashka in order to your package works?

@Sohalt
Copy link
Contributor Author

Sohalt commented Nov 11, 2022

Exactly.

@Sohalt Sohalt marked this pull request as ready for review December 7, 2022 15:41
@Sohalt
Copy link
Contributor Author

Sohalt commented Dec 7, 2022

Should work now with the newer babashka in nixpkgs.

@AndersonTorres AndersonTorres merged commit 15b09f2 into NixOS:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants