-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bbin: init at 0.1.4 #200195
bbin: init at 0.1.4 #200195
Conversation
251a4f0
to
3951393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
Thanks @AndersonTorres for the review! I addressed all your points.
when trying to execute a script installed with bbin. |
Ok, the issue is that the check for whether |
So you need a new babashka in order to your package works? |
Exactly. |
Should work now with the newer babashka in nixpkgs. |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes