Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxcrypt: 4.4.31 -> 4.4.33 #201653

Merged
merged 1 commit into from
Nov 20, 2022
Merged

libxcrypt: 4.4.31 -> 4.4.33 #201653

merged 1 commit into from
Nov 20, 2022

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 17, 2022 •
edited
Loading

patch is not load with fetchpatch since we don't have this during stdenv bootstrapping.

Description of changes

Still waiting to compile...

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 marked this pull request as ready for review November 17, 2022 19:36
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild labels Nov 17, 2022
@ofborg ofborg bot requested a review from mweinelt November 17, 2022 20:21
@Mic92 Mic92 mentioned this pull request Nov 17, 2022
Closed
@mweinelt
Copy link
Member

We asked upstream to provide a release, and since they've been pretty responsive we can wait a few days for their feedback.

@mweinelt mweinelt marked this pull request as draft November 17, 2022 20:38
@Mic92 Mic92 marked this pull request as ready for review November 18, 2022 09:44
@Mic92
Copy link
Member Author

Mic92 commented Nov 18, 2022

There we go.

@mweinelt
Copy link
Member

Please reference the release notes in the commit message as per CONTRIBUTING.md 😉

@mweinelt mweinelt changed the title libxcrypt: fix on systems with 1GiB hugetables libxcrypt: 4.4.31 -> 4.4.33 Nov 18, 2022
@applePrincess applePrincess added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 19, 2022
@Mic92 Mic92 merged commit 5e9519e into NixOS:staging Nov 20, 2022
@Mic92 Mic92 deleted the libxcrypt branch November 20, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trofi trofi trofi approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mic92 @mweinelt @trofi @applePrincess