Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/backport-action 0.0.8 -> 0.0.9 #202500

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Conversation

mweinelt
Copy link
Member

https://github.com/zeebe-io/backport-action/releases/tag/v0.0.9

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested review from a team, Mic92 and zowoq as code owners November 23, 2022 11:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 23, 2022
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine and upstream changelog looks also fine.

@@ -26,7 +26,7 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- name: Create backport PRs
uses: zeebe-io/[email protected].8
uses: zeebe-io/[email protected].9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: zeebe-io/[email protected]
uses: zeebe-io/backport-action@2ee900dc92632adf994f8e437b6d16840fd61f58 # tag=v0.0.9

How do you feel about pinning the action to the specific commit?

This could help in the situation where the upstream repository of the action is compromised is some ways (especially since the job has some write permissions).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this has already been discussed in #140301, sorry for the noise and feel free to disregard my comment. Dependabot support has however been improved since then and updating the commit reference and the associated comment is not an issue anymore (see dependabot/dependabot-core#5951)

@Mic92 Mic92 merged commit 6c7a25e into NixOS:master Nov 27, 2022
@mweinelt mweinelt deleted the backport-0.0.9 branch November 27, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants