gnvim: 0.1.6 -> 0.3.1

[minijackson]

Description of changes

Changes:

• https://github.com/vhakulinen/gnvim/releases/tag/v0.3.0
• https://github.com/vhakulinen/gnvim/releases/tag/v0.3.1

Also fix build on Darwin.

ZHF: #230712

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[teto]

works on linux but other platforms dont like the change

[raphaelr]

works on linux but other platforms dont like the change

gnvim-unwrapped builds, the problem is the wrapper

imo the gnvim.app is an artifact from the time where gnvim depended on webkitgtk, and is not needed anymore. So I'd replace the wrapper with something like

buildCommand = ''
    makeWrapper '${gnvim-unwrapped}/bin/gnvim' "$out/bin/gnvim" \
      --prefix PATH : "${neovim}/bin" \
      --set GNVIM_RUNTIME_PATH "${gnvim-unwrapped}/share/gnvim/runtime"
    mkdir -p "$out/share"
  '' + lib.optionalString (!stdenv.isDarwin) ''
    ln -s '${gnvim-unwrapped}/share/icons' "$out/share/icons"
    # copy and fix .desktop file
    cp -r '${gnvim-unwrapped}/share/applications' "$out/share/applications"
    # Sed needs a writable directory to do inplace modifications
    chmod u+rw "$out/share/applications"
    sed -e "s|Exec=.\\+gnvim\\>|Exec=gnvim|" -i $out/share/applications/*.desktop
  '';

That should at least make the build process happy

[Icy-Thought]

@minijackson are you still interested in getting this PR merged?

[teto]

ping. would be nice to have in 23.05

[minijackson]

Sorry for the delay. Can someone test on darwin?

[teto]

I am tempted to merge as is as it's hard to get darwin users. At least it builds. What do you think ? I would merge the commits 0.2 -> 0.3 and 0.3 -> 0.3.1 together + merged the darwin fix with the previous commit.

[minijackson]

@teto Considering the darwin build failure went unnoticed for a while, I think that's fine, yeah.