hugin: disallow EGL-enabled wxGTK with non-EGL-enabled GLEW #204741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hugin will segfault on startup if linked against an EGL-enabled wxGTK and also linked against a NON-EGL-enabled GLEW. This has been a problem for quite some time: https://www.mail-archive.com/[email protected]/msg07856.html https://bbs.archlinux.org/viewtopic.php?pid=2047383#p2047383 Since nixpkgs' wxGTK is, by default, EGL-enabled, let's have hugin link against `glew-egl`. This commit also exposes a `passthru` for each of `wxGTK` and `glew` advertising their EGL-ish-ness, and adds an `assert` in `hugin/default.nix` to prevent building with incompatible linkage.
ofborg
bot
added
10.rebuild-darwin: 0
|
GTK honestly goes a little over my head for how it should be configured, would this fix I made a working patch using |
|
I ultimately didn't end up using |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Hugin will segfault on startup if linked against an EGL-enabled wxGTK and also linked against a NON-EGL-enabled GLEW.
This has been a problem for quite some time:
https://www.mail-archive.com/[email protected]/msg07856.html
https://bbs.archlinux.org/viewtopic.php?pid=2047383#p2047383
Since nixpkgs' wxGTK is, by default, EGL-enabled, let's have hugin link against
glew-egl. This commit also exposes apassthrufor each ofwxGTKandglewadvertising their EGL-ish-ness, and adds anassertinhugin/default.nixto prevent building with incompatible linkage.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes