Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypy27, pypy39: unbreak on aarch64-darwin #209699

Merged
merged 1 commit into from
Jan 8, 2023
Merged

pypy27, pypy39: unbreak on aarch64-darwin #209699

merged 1 commit into from
Jan 8, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 8, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 8, 2023
@ofborg ofborg bot requested a review from andersk January 8, 2023 14:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 8, 2023
@wegank wegank changed the title pypy27: unbreak on aarch64-darwin pypy27, pypy39: unbreak on aarch64-darwin Jan 8, 2023
@wegank wegank marked this pull request as ready for review January 8, 2023 14:49
@wegank wegank requested a review from FRidh as a code owner January 8, 2023 14:49
@wegank wegank marked this pull request as draft January 8, 2023 14:57
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 8, 2023
@wegank wegank force-pushed the pypy27-darwin branch 2 times, most recently from 64bfbd5 to e474185 Compare January 8, 2023 15:46
@wegank wegank marked this pull request as ready for review January 8, 2023 15:48
@wegank wegank force-pushed the pypy27-darwin branch 3 times, most recently from 25f8514 to 1ba2324 Compare January 8, 2023 17:14
@wegank wegank mentioned this pull request Jan 8, 2023
Merged
13 tasks
@thiagokokada thiagokokada merged commit 7b71b02 into NixOS:master Jan 8, 2023
@wegank wegank deleted the pypy27-darwin branch January 8, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@andersk andersk Awaiting requested review from andersk

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @thiagokokada