matrix-conduit: 0.4.0 -> 0.5.0 #211309
Closed
matrix-conduit: 0.4.0 -> 0.5.0 #211309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
reviewed
Jan 18, 2023
| depsExtraArgs.postBuild = '' | ||
| sed 's/serde = { workspace = true/serde = { features = [ "derive" ], version = "*"/g' -i $name/ruma*/Cargo.toml | ||
| sed 's/tracing = { workspace = true.*/tracing = { version = "*" }/g' -i $name/ruma*/Cargo.toml | ||
| sed 's/workspace = true/version = "*"/g' -i $name/ruma*/Cargo.toml |
There was a problem hiding this comment.
Minor nitpick, but I'd do this which I think is easier to read:
sed -i $name/ruma*/Cargo.toml \
-e 's/serde = { workspace = true/serde = { features = [ "derive" ], version = "*"/g' \
-e 's/tracing = { workspace = true.*/tracing = { version = "*" }/g' \
-e 's/workspace = true/version = "*"/g'There was a problem hiding this comment.
That is of course assuming we cannot simply remove "workspace = true".
|
One more thing - we should also change the module as the service can now run with |
Comment on lines
+19
to
+21
| -e 's/serde = { workspace = true/serde = { features = [ "derive" ], version = "*"/g' \ | ||
| -e 's/tracing = { workspace = true.*/tracing = { version = "*" }/g' \ | ||
| -e 's/workspace = true/version = "*"/g' |
There was a problem hiding this comment.
I would rather use a patch here to make the change more obvious and fail if some part does not apply with the next update.
There was a problem hiding this comment.
That's a very good point. I'm with @SuperSandro2000 on this.
|
I don't know how to do this, since it is not part of the source code of the application. Either way, someone else can finish this. |
13 tasks
|
Continuation in #212036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Involves some hacks
#202762
rust-lang/cargo#11192
ruma/ruma#1441
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes