Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove global with lib; statements in pkgs/coq-modules #212009

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Shawn8901
Copy link
Contributor

Description of changes

I am trying to split #211241 into smaller changes to get it into a reviewable bulk and try to approach that in smaller groups by pkgs category.

This PR removes the global with lib; statements of pkgs/coq-modules.

I tried to follow the rule to replace all with lib; with lib. but if its for the meta attr. For meta i replaced it with meta = with lib; { if there was no other scoping before that. It there was other scoping i tried to follow that.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 21, 2023
@wegank
Copy link
Member

wegank commented Jan 24, 2023

@ofborg build coqPackages.category-theory

@wegank
Copy link
Member

wegank commented Jan 24, 2023

LGTM + ofborg reports no changes.

@wegank wegank merged commit 8ff706b into NixOS:master Jan 24, 2023
@Shawn8901 Shawn8901 deleted the remove_with_lib_2 branch January 24, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants