{documentation-highlighter,zsh-clipboard}: Remove dependency on Nix files #212336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the build independency of the default.nix and update.sh file by explicitly specifying the files that are needed in the result This allows changing those files without causing a rebuild
bb2020
reviewed
Jan 24, 2023
| @@ -4,13 +4,13 @@ stdenv.mkDerivation rec { | |||
| pname = "zsh-clipboard"; | |||
| version = "1.0"; | |||
|
|
|||
| src = ./.; | |||
| dontUnpack = true; | |||
|
|
|||
There was a problem hiding this comment.
Can we put dontBuild = true; here?
There was a problem hiding this comment.
It's already there further down, but dontUnpack is also needed.
There was a problem hiding this comment.
I meant removing the empty line (8th line).
There was a problem hiding this comment.
I guess that could be done yeah
This way, changing the Nix file won't change the derivation
infinisil
force-pushed
the
some-nix-file-deps
branch
from
d66bed8 to
ebc0798
Compare
bb2020
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
pkgs.documentation-highlighterandpkgs.zsh-clipboardcurrently depend on the Nix files that define them, meaning that they have to be rebuilt whenever those files change. This PR fixes that.Note that the NixOS and nixpkgs manuals depend on
documentation-highlighter(ping @grahamc), I verified that they still build.This was noticed while working on #211832.
Things done
On x86_64-linux:
nix-build -A documentation-highlighternix-build -A zsh-clipboardnix-build nixos/release.nix -A manualHTML.x86_64-linuxnix-build doc