openssl: run make install with -j$NIX_BUILD_CORES
#212918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl3 runs `pod2man` as part of `make install`, which means that the installPhase takes longer than the buildPhase without this.
ghost
marked this pull request as ready for review
Atemu
reviewed
Jan 27, 2023
Comment on lines
+157
to
+158
| # openssl3 runs `pod2man` as part of `make install`, which means that the | ||
| # installPhase takes longer than the buildPhase without this: |
There was a problem hiding this comment.
Are you sure it's not simply reaching a previously unbuilt doc target or thereof in order to reach the install target?
In that case you should rather make the buildPhase explicitly build that target in addition to the regular targets via buildFlags.
ofborg
bot
added
10.rebuild-darwin-stdenv
|
Superseded by #217568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The kernel building derivation does the same thing.
Maybe it's time for
setup.shto learnenableParallelInstall=true?Things done