qt5/qtbase.nix: add mysqlSupport #220312
Merged
qt5/qtbase.nix: add mysqlSupport #220312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
ofborg
bot
added
10.rebuild-darwin: 0
Artturin
reviewed
Mar 9, 2023
This commit switches `libmysqlclient`-enablement from `!=null`-style to `fooSupport`-style, by adding an additional boolean parameter `mysqlSupport`. This parameter defaults to `stdenv.hostPlatform==stdenv.buildPlatform`, so there should be no change in behavior for the non-cross-compiling case. Co-authored-by: Artturi <[email protected]>
|
Squashed, updated commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit switches
libmysqlclient-enablement from!=null-style tofooSupport-style, by adding an additional boolean parametermysqlSupport.This parameter defaults to
stdenv.hostPlatform==stdenv.buildPlatform, so there should be no change in behavior for the non-cross-compiling case.