Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atuin: fix darwin build #224411

Merged
merged 1 commit into from
Apr 2, 2023
Merged

atuin: fix darwin build #224411

merged 1 commit into from
Apr 2, 2023

Conversation

happysalada
Copy link
Contributor

Description of changes

cargohash is indeed different on darwin and linux

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 2, 2023
@happysalada happysalada requested a review from 0x4A6F April 2, 2023 22:39
@happysalada happysalada mentioned this pull request Apr 2, 2023
Merged
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 2, 2023
@figsoda figsoda merged commit b86e23f into NixOS:master Apr 2, 2023
@happysalada happysalada deleted the atuin_fix_darwin_build branch April 28, 2023 19:56
@jian-lin jian-lin mentioned this pull request Apr 30, 2024
Open
@poopsicles poopsicles mentioned this pull request Dec 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@figsoda figsoda figsoda approved these changes

@0x4A6F 0x4A6F Awaiting requested review from 0x4A6F

@Sciencentistguy Sciencentistguy Awaiting requested review from Sciencentistguy

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@happysalada @SuperSandro2000 @figsoda