gnat-bootstrap: parameterize better #226179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build gnat11 gnat12 |
ofborg
bot
added
8.has: clean-up
8.has: package (new)
This comment was marked as resolved.
This comment was marked as resolved.
ghost
marked this pull request as draft
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This commit makes `url` dependent on the gnat version, and allows
for `alireRevision` to be empty (in which case no hyphen is added
after ${gccVersion} in `version`).
This should cause no changes to eval on `gnat11` or `gnat12`.
This is submitted in order to reduce the size of #225191
ghost
marked this pull request as ready for review
ofborg
bot
added
10.rebuild-darwin: 0
|
This lgtm, but really only if #225191 is going to be merged. Otherwise not worth it imo. |
|
@ofborg eval |
|
Included in #225191 which has two approvals. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: note: this includes gnatboot: rename to gnat-bootstrap from #225191 which I have asked @mmlb to submit as a separate PR. I'll rebase on top of that PR once it is submitted.
Description of changes
This commit makes
urldependent on the gnat version, and allows foralireRevisionto be empty (in which case no hyphen is added after ${gccVersion} inversion).This should cause no changes to eval on
gnat11orgnat12.This is submitted in order to reduce the size of #225191
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)