Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anki: allow using wayland on linux #226426

Merged
merged 1 commit into from
Apr 16, 2023
Merged

anki: allow using wayland on linux #226426

merged 1 commit into from
Apr 16, 2023

Conversation

sbruder
Copy link
Contributor

@sbruder sbruder commented Apr 16, 2023

Description of changes

This makes the native version of Anki use Wayland natively (without xwayland).

This patch had already been applied in #221229, though I think it got lost while converting the package to importCargoLock.
Is that correct @euank, or was it removed for some other reason?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sbruder sbruder requested a review from euank April 16, 2023 09:07
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

I didn't mean to lose this, I think I messed up a rebase 😅, and I'm still on X11 so I didn't test wayland after every change.

Thanks again for catching my mistake here!

@sbruder
Copy link
Contributor Author

sbruder commented Apr 16, 2023

No problem. Thanks to you for adding the native Anki version (and also figuring out how to make it work with Wayland in the original PR)!

@ofborg ofborg bot requested review from oxij, euank and Profpatsch April 16, 2023 09:37
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 16, 2023
@wegank wegank merged commit 1eea8d5 into NixOS:master Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants