linux/kernel/generic.nix: assert if constraints would be ignored #227999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a real mess with the naming of the attribute which contains structured extra configuration: - Nixpkgs' linux kernel expression uses structuredExtraConfig. - NixOS uses extraStructuredConfig. - Nixpkgs' kernelPatches use extraStructuredConfig. At the moment, if the user uses the wrong convention the configuration constraints are silently dropped. Let's `assert` instead so they at least know that their request isn't being respected. We can try to harmonize the naming later.
ofborg
bot
added
10.rebuild-darwin: 0
|
wouldn't it be better to standardize on extraStructuredConfig ? |
ghost
mentioned this pull request
5 tasks
Maybe, but that's a separate issue. This attribute is exposed to users outside of nixpkgs, so we need to add an I don't particularly care which spelling is used, but silently ignoring things is strictly worse than either choice. |
ghost
deleted the
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/improving-custom-configuration-for-alternate-kernels/45240/2 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
There appears to be a real mess with the naming of the attribute which contains structured extra configuration:
At the moment, if the user uses the wrong convention the configuration constraints are silently dropped. Let's
assertinstead so they at least know that their request isn't being respected. We can try to harmonize the naming later.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)