oculante: (really) fix wayland #230034
Closed
oculante: (really) fix wayland #230034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cherry-picks a patch which is merged upstream but unreleased. The patch reverts obnoxious behavior in all previous versions of oculante which would force X11 *even when $DISPLAY is unset*.
ghost
requested a review
from 
|
Ah, nevermind, they finally released it #229384 |
ghost
closed this
|
That commit is in tagged releases, I'm the one that suggested it upstream.
The PR bumping version and fixing Wayland was merged yesterday.
…On Thu, May 4, 2023, 22:48 Adam Joseph ***@***.***> wrote:
@amjoseph-nixpkgs <https://github.com/amjoseph-nixpkgs> requested your
review on: #230034 <#230034>
oculante: (really) fix wayland.
—
Reply to this email directly, view it on GitHub
<#230034 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACP25EK6EQJ7F6JUH7CHZDXESBBDANCNFSM6AAAAAAXWUDVX4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Ah got the email a second too late
…On Thu, May 4, 2023, 22:50 Cole Mickens ***@***.***> wrote:
That commit is in tagged releases, I'm the one that suggested it upstream.
The PR bumping version and fixing Wayland was merged yesterday.
On Thu, May 4, 2023, 22:48 Adam Joseph ***@***.***> wrote:
> @amjoseph-nixpkgs <https://github.com/amjoseph-nixpkgs> requested your
> review on: #230034 <#230034>
> oculante: (really) fix wayland.
>
> —
> Reply to this email directly, view it on GitHub
> <#230034 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AACP25EK6EQJ7F6JUH7CHZDXESBBDANCNFSM6AAAAAAXWUDVX4>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit cherry-picks a patch which is merged upstream but unreleased. The patch reverts obnoxious behavior in all previous versions of oculante which would force X11 even when $DISPLAY is unset.
Things done