openbugs: init at 3.2.3

[andres-nav]

Description of changes

Uploaded a new package calles OpenBUGS and added myself as a maintainer.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[nevivurn]

Thank you, lgtm!

[nevivurn]

While looking at something else, I discovered stdenv_32bit:

  # A stdenv capable of building 32-bit binaries.
  # On x86_64-linux, it uses GCC compiled with multilib support; on i686-linux,
  # it's just the plain stdenv.
  stdenv_32bit = lowPrio (if stdenv.hostPlatform.is32bit then stdenv else multiStdenv);

which probably does what we want here, though I'm not sure if it's preferred.

[andres-nav]

You were right, now it works for 32 bits also. I have tried it and it compiles and runs smoothly. I have just made a small tweak in the buildInputs.

[nevivurn]

Sorry, I meant that we can swap out stdenv for stdenv_32bit entirely, and omit the references to gcc_multi and nativeBuildInputs. While we're at it, we should leave a comment explaining why we have to use stdenv_32bit.

Kind of like https://github.com/nixos/nixpkgs/blob/master/pkgs/tools/misc/loadlibrary/default.nix

It still needs to be viewed by someone with commit privileges (I'm new to nixpkgs too).

[andres-nav]

Yes, I understood you but I think this way it is cleaner and better as you can see de dependences explicitly.
I can modify to stdenv_32bit but I prefer this way.

Is there any other advantage using stdenv_32bit?

No problem, thank you for your work.

[nevivurn]

OK, in that case LGTM for now 👍

[alyssais]

This package is really only supported on 32-bit x86, right? The gcc_multi thing is a bit of a hack. So probably it would make more sense to only support 32-bit in the package, but tell 64-bit Linux to use the 32-bit version?

(But I'm not a multilib expert, so I'm happy to be corrected by somebody who knows more about how we usually handle this stuff — I just note that we don't have any other packages directly using gcc_multi apart from LLVM, but a few packages that use pkgsi686Linux.callPackage.)

[alyssais]

@ofborg build openbugs

[alyssais]

Thanks for the contribution!

[github-actions]

Backport failed for release-22.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.11
git worktree add -d .worktree/backport-233506-to-release-22.11 origin/release-22.11
cd .worktree/backport-233506-to-release-22.11
git checkout -b backport-233506-to-release-22.11
ancref=$(git merge-base 05c30cbde364894fa3a774fb62e78b96b9a93f0f cfbff1faffc96af3dc4223fa12f6f4da6077decc)
git cherry-pick -x $ancref..cfbff1faffc96af3dc4223fa12f6f4da6077decc

[github-actions]

Successfully created backport PR for release-23.05:

• [Backport release-23.05] openbugs: init at 3.2.3 #234617

[alyssais]

Don't worry about the 22.11 backport. It only has a month or so of support left anyway.

[andres-nav]

Awesome! Thank you very much.