-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: fix build with case-sensitive store on Darwin #234105
Conversation
Two basic questions:
As I have said before, I have no access to a Darwin machine. |
The patch shouldn’t affect users on case-insensitive stores. All it does is change the casing of |
Co-authored-by: Weijia Wang <[email protected]>
@ofborg build meson meson.passthru.tests |
It is now merged upstream. |
Description of changes
I run Darwin with a case-sensitive store because it’s offered as an option. Meson is the first thing that actually broke because of it. This patch corrects the casing of “foundation” references in some of the tests that expect to find it.
I did not run
nixpkgs-review
because this change causes a lot of rebuilds, but I did rebuild a number of packages as part of my work on #229786.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)