gperf: fix build with clang 16 #235120
Merged
gperf: fix build with clang 16 #235120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 16 defaults to C++17, which does not allow the `register` storage class specifier. This is fixed upstream, but the change doesn’t apply cleanly to the 3.1 release. Fortunately, the fix is trivial (remove the disallowed keyword).
trofi
approved these changes
May 31, 2023
There was a problem hiding this comment.
LGTM. Another option is to update to 3.2 which should contain the same fix: https://git.savannah.gnu.org/gitweb/?p=gperf.git;a=commitdiff;h=a63b830554920476881837eeacd4a6b507632b19
|
I see the commit, but has there been an official release? There isn’t a |
|
Ah, good point. I though that https://git.savannah.gnu.org/gitweb/?p=gperf.git;a=commitdiff;h=6d53a2dbe0ad692d0f36fd394b7e1962d9a81730 implied there is a proper release. My apologies. UPDATE: related upstream bug: https://savannah.gnu.org/bugs/?62139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Clang 16 defaults to C++17, which does not allow the
registerstorage class specifier. This is fixed upstream, but the change doesn’t apply cleanly to the 3.1 release. Fortunately, the fix is trivial (remove the disallowed keyword).Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)