Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volk: add -DVOLK_CPU_FEATURES=OFF if isPower64 #237267

Closed
wants to merge 1 commit into from
Closed

volk: add -DVOLK_CPU_FEATURES=OFF if isPower64 #237267

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2023

Description of changes

Three of the volk tests segfault on powerpc64le without -DVOLK_CPU_FEATURES=OFF. Let's add -DVOLK_CPU_FEATURES=OFF so the tests pass.

volk> 136/139 Test #135: qa_volk_8u_conv_k7_r2puppet_8u .......................   Passed    0.03 sec
volk> 137/139 Test  #97: qa_volk_32fc_s32fc_multiply_32fc .....................***Failed    0.16 sec
volk> RUN_VOLK_TESTS: volk_32fc_s32fc_multiply_32fc(131071,1)
volk> /build/source/build/lib/volk_32fc_s32fc_multiply_32fc_test.sh: line 6:  1388 Segmentation fault      (core dumped) volk_test_all volk_32fc_s32fc_multiply_32fc
volk> 138/139 Test #107: qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc ....***Failed    0.15 sec
volk> RUN_VOLK_TESTS: volk_32fc_x2_s32fc_multiply_conjugate_add_32fc(131071,1)
volk> Volk warning: no arch found, returning generic impl
volk> /build/source/build/lib/volk_32fc_x2_s32fc_multiply_conjugate_add_32fc_test.sh: line 6:  1407 Segmentation fault      (core dumped) volk_test_all volk_32fc_x2_s32fc_multiply_conjugate_add_32fc
volk> 139/139 Test  #98: qa_volk_32fc_s32fc_rotatorpuppet_32fc ................***Failed    0.17 sec
volk> RUN_VOLK_TESTS: volk_32fc_s32fc_rotatorpuppet_32fc(131071,1)
volk> /build/source/build/lib/volk_32fc_s32fc_rotatorpuppet_32fc_test.sh: line 6:  1390 Segmentation fault      (core dumped) volk_test_all volk_32fc_s32fc_rotatorpuppet_32fc
volk> 98% tests passed, 3 tests failed out of 139
volk> Total Test time (real) =   0.37 sec
volk> The following tests FAILED:
volk>          97 - qa_volk_32fc_s32fc_multiply_32fc (Failed)
volk>          98 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed)
volk>         107 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed)
volk> Errors while running CTest
volk> make: *** [Makefile:71: test] Error 8
error: build of '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' on 'ssh://root@sterling' failed: builder for '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' failed with exit code 2
error: builder for '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' failed with exit code 1;
       last 10 log lines:
       > 98% tests passed, 3 tests failed out of 139
       >
       > Total Test time (real) =   0.37 sec
       >
       > The following tests FAILED:
       >          97 - qa_volk_32fc_s32fc_multiply_32fc (Failed)
       >          98 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed)
       >         107 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed)
       > Errors while running CTest
       > make: *** [Makefile:71: test] Error 8
       For full logs, run 'nix log /nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv'.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Three of the volk tests segfault on powerpc64le without
`-DVOLK_CPU_FEATURES=OFF`.  Let's add `-DVOLK_CPU_FEATURES=OFF` so
the tests pass.

```
volk> 136/139 Test #135: qa_volk_8u_conv_k7_r2puppet_8u .......................   Passed    0.03 sec
volk> 137/139 Test  #97: qa_volk_32fc_s32fc_multiply_32fc .....................***Failed    0.16 sec
volk> RUN_VOLK_TESTS: volk_32fc_s32fc_multiply_32fc(131071,1)
volk> /build/source/build/lib/volk_32fc_s32fc_multiply_32fc_test.sh: line 6:  1388 Segmentation fault      (core dumped) volk_test_all volk_32fc_s32fc_multiply_32fc
volk> 138/139 Test #107: qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc ....***Failed    0.15 sec
volk> RUN_VOLK_TESTS: volk_32fc_x2_s32fc_multiply_conjugate_add_32fc(131071,1)
volk> Volk warning: no arch found, returning generic impl
volk> /build/source/build/lib/volk_32fc_x2_s32fc_multiply_conjugate_add_32fc_test.sh: line 6:  1407 Segmentation fault      (core dumped) volk_test_all volk_32fc_x2_s32fc_multiply_conjugate_add_32fc
volk> 139/139 Test  #98: qa_volk_32fc_s32fc_rotatorpuppet_32fc ................***Failed    0.17 sec
volk> RUN_VOLK_TESTS: volk_32fc_s32fc_rotatorpuppet_32fc(131071,1)
volk> /build/source/build/lib/volk_32fc_s32fc_rotatorpuppet_32fc_test.sh: line 6:  1390 Segmentation fault      (core dumped) volk_test_all volk_32fc_s32fc_rotatorpuppet_32fc
volk> 98% tests passed, 3 tests failed out of 139
volk> Total Test time (real) =   0.37 sec
volk> The following tests FAILED:
volk>          97 - qa_volk_32fc_s32fc_multiply_32fc (Failed)
volk>          98 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed)
volk>         107 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed)
volk> Errors while running CTest
volk> make: *** [Makefile:71: test] Error 8
error: build of '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' on 'ssh://root@sterling' failed: builder for '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' failed with exit code 2
error: builder for '/nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv' failed with exit code 1;
       last 10 log lines:
       > 98% tests passed, 3 tests failed out of 139
       >
       > Total Test time (real) =   0.37 sec
       >
       > The following tests FAILED:
       >          97 - qa_volk_32fc_s32fc_multiply_32fc (Failed)
       >          98 - qa_volk_32fc_s32fc_rotatorpuppet_32fc (Failed)
       >         107 - qa_volk_32fc_x2_s32fc_multiply_conjugate_add_32fc (Failed)
       > Errors while running CTest
       > make: *** [Makefile:71: test] Error 8
       For full logs, run 'nix log /nix/store/0z75gmgmgvdddzl6m0qblbnxrzaddjhy-volk-3.0.0.drv'.
```
@ghost ghost marked this pull request as draft June 12, 2023 00:01
@ghost
Copy link
Author

ghost commented Jun 12, 2023

Nope, this doesn't fix it.

@ghost ghost closed this Jun 12, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 12, 2023
@ghost ghost deleted the pr/volk/powerpc64le branch June 12, 2023 00:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants