Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost{175,176,177,178,179,180}: clang 16 and libc++ 15 fixes #240642

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

These fixes are upstream in the latest version. These commits cherry pick the patches back to the currently provided boost packages in nixpkgs to allow them to build with clang 16 and libc++ 15+ once the Darwin stdenv is updated.

Compilation of all boost packages was tested. Builds were tested with packages that had boost as a dependency.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

libc++ 15 dropped support for `std::unary_function` and
`std::binary_function` in C++17 and C++20. C++17 is the default for
clang 16, but clang 15 is also affected in those language modes.

This incompatibility is fixed in Boost 1.81, but the late patch for
Boost 1.80 applies to earlier versions and allows those versions to
build with clang 16 (and clang 15 in the affected modes).
Clang 16 began diagnosing ill-formed constant expressions for values
outside the range of enums without a fixed underlying type. While the
error can be suppressed, it will become a hard error in clang 17.
@wegank
Copy link
Member

wegank commented Jun 30, 2023

@ofborg build boost175 boost177 boost178 boost179 boost180

@wegank wegank merged commit fe35cda into NixOS:staging Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants