-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppsspp: 1.1.0 -> 1.3 #24272
ppsspp: 1.1.0 -> 1.3 #24272
Conversation
@therealpxc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AndersonTorres, @abbradar and @Fuuzetsu to be potential reviewers. |
attn @ndowens this is my resubmit of the old PR for the same thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the maintainers field you can do
maintainers = with maintainers; [ name1 name 2]; since there are more than one maintainers. But other than that looks good
Cleaned up the maintainers field as you suggested. :-) |
Does it work? IIRC some old version of ppsspp started to segfault straight away on me (hence why it was in 1.0 for ages) |
Yes, it does work. I logged many hours with this version (on NixOS 16.09) a couple months ago. I don't have time to do the same kind of ‘testing’ right now for master or NixOS 17.03, but I encourage you to give it a try and let me know if there are any problems on your end. I don't expect the one you've described, although I have experienced occasional segfaults in the middle of use (not enough to get me to throw my controller in frustration or anything, I mean like once or twice over the course of a few days with hours of play on each). I can confirm that it does not segfault on startup, though. I tested that far last night with this very branch. The GUI opens and looks and behaves like it's supposed to. |
Can I ask what's going on with Travis CI, btw? It seems like literally every time I view a NixOS PR, it says the build has failed. What's up with that? |
It has been having issues. I can't explain why, but lately it is normal
…On Fri, Mar 24, 2017 at 9:25 PM, Patrick Callahan ***@***.***> wrote:
Can I ask what's going on with Travis CI, btw? It seems like literally
every time I view a NixOS PR, it says the build has failed. What's up with
that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24272 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHL7wT1NTIr7ok72wcqdLC6srAL7_AEks5rpHsvgaJpZM4MnqUO>
.
|
Darwin build fails https://travis-ci.org/NixOS/nixpkgs/jobs/214740202, is that expected? If nobody cares to fix it, perhaps darwin should be removed from platforms. |
It's better to exclude it. Well, I don't know the specific status of Darwin on NixOS/Nixpkgs, then I think it is better to not put so much worry trying to port anything to it (at least for now). |
I would try my hand at it, but I don't own a Mac and I am (for the next few weeks at least) still a student, so I'm not about to buy one. I think it's cool that in principle Nix is cross-platform, so if I had some money it would be different. So I agree with the consensus that for now we should drop it, pending any volunteers on the OS X side. |
About it, I am thinking about work the FreeBSD and BSDs in general about cross-platform and portability issues. But I need more time management in my real life issues. |
@AndersonTorres I feel personally attacked by this relatable content 😉 |
Motivation for this change
new upstream release
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)