Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport release-23.05] tuxedo-keyboard: 3.1.4 -> 3.2.7 #243426

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

blitz
Copy link
Contributor

@blitz blitz commented Jul 14, 2023

Description of changes

This PR backports these PRs to fix building tuxedo-keyboard against linux_latest (6.4):

They patches apply cleanly. I'm running them right now on my Tuxedo laptop without issues.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

xaverdh added 2 commits July 14, 2023 09:37
(cherry picked from commit 81a9774)
(cherry picked from commit 95026c0)
@blitz blitz requested review from drupol, xaverdh and blanky0230 July 14, 2023 08:21
@blitz
Copy link
Contributor Author

blitz commented Jul 14, 2023

Result of nixpkgs-review pr 243426 run on x86_64-linux 1

6 packages failed to build:
  • linuxKernel.packages.linux_4_14.tuxedo-keyboard
  • linuxKernel.packages.linux_4_14_hardened.tuxedo-keyboard
  • linuxKernel.packages.linux_4_19.tuxedo-keyboard
  • linuxKernel.packages.linux_4_19_hardened.tuxedo-keyboard
  • linuxKernel.packages.linux_5_4.tuxedo-keyboard
  • linuxKernel.packages.linux_5_4_hardened.tuxedo-keyboard
16 packages built:
  • linuxKernel.packages.linux_5_10.tuxedo-keyboard
  • linuxKernel.packages.linux_5_10_hardened.tuxedo-keyboard
  • linuxKernel.packages.linux_5_15.tuxedo-keyboard
  • linuxKernel.packages.linux_5_15_hardened.tuxedo-keyboard
  • linuxKernel.packages.linux_6_1.tuxedo-keyboard
  • linuxKernel.packages.linux_hardened.tuxedo-keyboard (linuxKernel.packages.linux_6_1_hardened.tuxedo-keyboard)
  • linuxKernel.packages.linux_6_3.tuxedo-keyboard
  • linuxKernel.packages.linux_6_3_hardened.tuxedo-keyboard
  • linuxKernel.packages.linux_6_4.tuxedo-keyboard
  • linuxKernel.packages.linux_latest_libre.tuxedo-keyboard
  • linuxKernel.packages.linux_libre.tuxedo-keyboard
  • linuxKernel.packages.linux_lqx.tuxedo-keyboard
  • linuxKernel.packages.linux_testing_bcachefs.tuxedo-keyboard
  • linuxKernel.packages.linux_xanmod.tuxedo-keyboard
  • linuxKernel.packages.linux_xanmod_latest.tuxedo-keyboard (linuxKernel.packages.linux_xanmod_stable.tuxedo-keyboard)
  • linuxKernel.packages.linux_zen.tuxedo-keyboard

@blitz
Copy link
Contributor Author

blitz commented Jul 14, 2023

Looks pretty good from my end. No one is going to run Linux <=5.4 on a laptop...

@blitz blitz requested a review from RaitoBezarius July 14, 2023 08:32
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jul 14, 2023
Copy link
Member

@blanky0230 blanky0230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drupol drupol merged commit 9fdfaeb into NixOS:release-23.05 Jul 14, 2023
@blitz blitz deleted the tuxedo-keyboard-3.2.7 branch July 14, 2023 22:11
@vcunat
Copy link
Member

vcunat commented Jul 15, 2023

Hydra doesn't think it's good:
https://hydra.nixos.org/eval/1797579#tabs-now-fail

@vcunat
Copy link
Member

vcunat commented Jul 15, 2023

OK, I guess you can consider kernels <= 5.4 unimportant. But then, please reflect that in meta.broken, so that Hydra doesn't need to try building it all the time. (nixpkgs master + backport)

@drupol
Copy link
Contributor

drupol commented Jul 15, 2023

Going to make a new PR fixing this.

@drupol
Copy link
Contributor

drupol commented Jul 15, 2023

@vcunat PR is ready at #243594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants