darwin.adv_cmds: fix build with clang 16

[reckenrode]

Description of changes

darwin.Libc conflicts with libc++ 16. adv_cmds only needs msgcat.h, so symlink it into the build from Libc instead of adding the whole thing to buildInputs.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[tjni]

Is it possible to create a derivation that picks out msgcat.h and use it in buildInputs? It's more machinery but I like it as it's more explicit (although I am not sure how the file gets into the gencat directory).

[reckenrode]

Is it possible to create a derivation that picks out msgcat.h and use it in buildInputs? It's more machinery but I like it as it's more explicit.

A derivation local to darwin.adv_cmds?

although I am not sure how the file gets into the gencat directory

The file doesn’t need to be there. It’s just that it can be found when putting it there, so that was an easy solution.

[tjni]

A derivation local to darwin.adv_cmds?

Yeah, a tiny one hidden away that plucks out (by linking or copying) just the file that we want.

[reckenrode]

Yeah, a tiny one hidden away that plucks out (by linking or copying) just the file that we want.

I pushed an updated commit taking that approach.