Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pytest-ansible: 3.1.5 -> 3.2.1 #246735

Merged
merged 2 commits into from
Aug 9, 2023
Merged

python3Packages.pytest-ansible: 3.1.5 -> 3.2.1 #246735

merged 2 commits into from
Aug 9, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 2, 2023

In addition, add missing nativeBuildInputs that are implicitly added right now, and configure setuptools-scm so that a _version.py file is created like in the PyPI archive.

https://github.com/ansible-community/pytest-ansible/releases/tag/v3.2.1
https://github.com/ansible-community/pytest-ansible/releases/tag/v3.2.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2508

@Janik-Haag Janik-Haag changed the title python3.pkgs.pytest-ansible: 3.1.5 -> 3.2.1 python3Pkgs.pytest-ansible: 3.1.5 -> 3.2.1 Aug 9, 2023
@Janik-Haag Janik-Haag changed the title python3Pkgs.pytest-ansible: 3.1.5 -> 3.2.1 python3Packages.pytest-ansible: 3.1.5 -> 3.2.1 Aug 9, 2023
@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 246735 run on x86_64-linux 1

4 packages built:
  • python310Packages.pytest-ansible
  • python310Packages.pytest-ansible.dist
  • python311Packages.pytest-ansible
  • python311Packages.pytest-ansible.dist

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except for the commit message. Can you change the commit message to the same as the Pull Request name?

In addition, add missing nativeBuildInputs that are implicitly added
right now, and configure setuptools-scm so that a _version.py file is
created like in the PyPI archive.
@tjni
Copy link
Contributor Author

tjni commented Aug 9, 2023

This looks good except for the commit message. Can you change the commit message to the same as the Pull Request name?

Thank you for reviewing! Done.

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

non blocker: but would you mind adding your self as a maintainer since the package currently doesn't have one?

@tjni
Copy link
Contributor Author

tjni commented Aug 9, 2023

No problem, done :)

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just waiting for ci now.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Aug 9, 2023
@Janik-Haag Janik-Haag merged commit e1cf478 into NixOS:master Aug 9, 2023
@tjni tjni deleted the pytest-ansible branch August 9, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants