-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pytest-ansible: 3.1.5 -> 3.2.1 #246735
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2508 |
Result of 4 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good except for the commit message. Can you change the commit message to the same as the Pull Request name?
In addition, add missing nativeBuildInputs that are implicitly added right now, and configure setuptools-scm so that a _version.py file is created like in the PyPI archive.
Thank you for reviewing! Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:
non blocker: but would you mind adding your self as a maintainer since the package currently doesn't have one?
No problem, done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, just waiting for ci now.
In addition, add missing nativeBuildInputs that are implicitly added right now, and configure setuptools-scm so that a _version.py file is created like in the PyPI archive.
https://github.com/ansible-community/pytest-ansible/releases/tag/v3.2.1
https://github.com/ansible-community/pytest-ansible/releases/tag/v3.2.0
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)